Attention is currently required from: fixeria, laforge.
dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/37641?usp=email )
Change subject: pySim-shell: enable export of DF and ADF files ......................................................................
Patch Set 2:
(2 comments)
File pySim-shell.py:
https://gerrit.osmocom.org/c/pysim/+/37641/comment/7b0ae629_92742cca?usp=ema... : PS1, Line 500: When walking through the file system tree the action must not : # always restore the currently selected file
I think the code is doing the opposite of what the comment states? IF the action *must not restore* […]
Thanks. The "not" is of course wrong.
https://gerrit.osmocom.org/c/pysim/+/37641/comment/b1d58645_73d2b54f?usp=ema... : PS1, Line 651: include_df
let's stick to using dash in command line arguments […]
We are using this style in many places. Maybe we should go through and fix it everywhere?