Attention is currently required from: fixeria, laforge.
View Change
2 comments:
File pySim-shell.py:
Patch Set #1, Line 500:
When walking through the file system tree the action must not
# always restore the currently selected file
I think the code is doing the opposite of what the comment states? IF the action *must not restore* […]
Thanks. The "not" is of course wrong.
Patch Set #1, Line 651: include_df
let's stick to using dash in command line arguments […]
We are using this style in many places. Maybe we should go through and fix it everywhere?
To view, visit change 37641. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I3ee661dbae5c11fec23911775f352ac13bc2c6e5
Gerrit-Change-Number: 37641
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy@sysmocom.de>
Gerrit-CC: laforge <laforge@osmocom.org>
Gerrit-Attention: laforge <laforge@osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Comment-Date: Mon, 05 Aug 2024 13:27:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge@osmocom.org>
Comment-In-Reply-To: fixeria <vyanitskiy@sysmocom.de>