laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/26865 ) Change subject: firmware: bugfix: disable cardemu comms in local SIM mode ...................................................................... Patch Set 1: Code-Review+1 (2 comments) nice catch, I think some minor cleanup would be appreciated. https://gerrit.osmocom.org/c/simtrace2/+/26865/1/firmware/libcommon/source/m... File firmware/libcommon/source/mode_cardemu.c: https://gerrit.osmocom.org/c/simtrace2/+/26865/1/firmware/libcommon/source/m... PS1, Line 87: /*! real-time state of VCC I/O line, irrespective of enabled flag */ normally we would split this in a separate cosmetic patch only adding the comments, to keep it separate from actual functional changes. https://gerrit.osmocom.org/c/simtrace2/+/26865/1/firmware/libcommon/source/m... PS1, Line 100: ; indeed, it is hard to see that an actual flag was added, because the reviewer (at least I in my first iteration) assumed that all added here were just some comments. -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/26865 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I4010f988712eac4a6af8568ccd60062f9de62449 Gerrit-Change-Number: 26865 Gerrit-PatchSet: 1 Gerrit-Owner: James Tavares <jtavares@kvh.com> Gerrit-Reviewer: Hoernchen <ewild@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Comment-Date: Tue, 11 Jan 2022 13:13:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment