nice catch, I think some minor cleanup would be appreciated.

Patch set 1:Code-Review +1

View Change

2 comments:

• File firmware/libcommon/source/mode_cardemu.c:

  • Patch Set #1, Line 87: /*! real-time state of VCC I/O line, irrespective of enabled flag */

    normally we would split this in a separate cosmetic patch only adding the comments, to keep it separate from actual functional changes.

  • Patch Set #1, Line 100: ;

    indeed, it is hard to see that an actual flag was added, because the reviewer (at least I in my first iteration) assumed that all added here were just some comments.

To view, visit change 26865. To unsubscribe, or for help writing mail filters, visit settings.