Attention is currently required from: Hoernchen, daniel.
dexter has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/pysim/+/43541?usp=email )
Change subject: ota: add TS 102 226 5.2 Expanded Remote Application data format ......................................................................
Patch Set 2: Code-Review+1
(4 comments)
Patchset:
PS2: This is really a lot of stuff, however the testcases look comprehensive. I think this is ok.
File pySim/ota.py:
https://gerrit.osmocom.org/c/pysim/+/43541/comment/7e48dc08_d9457744?usp=ema... : PS2, Line 120: Looks like a spec ref is missing here? (TS 102 226 5.2.1 as it seems)
https://gerrit.osmocom.org/c/pysim/+/43541/comment/fd096896_42e464c6?usp=ema... : PS2, Line 323: I would recommend to add API docstrings for the other parameters, in particular the apdu parameter, which now can also be a list of APDUs.
https://gerrit.osmocom.org/c/pysim/+/43541/comment/c6b1a88c_e552ac3c?usp=ema... : PS2, Line 333: same here, I think we should document all parameters.