Attention is currently required from: Hoernchen, daniel.

Patch set 2:Code-Review +1

View Change

4 comments:

• Patchset:

  • Patch Set #2:

    This is really a lot of stuff, however the testcases look comprehensive. I think this is ok.

• File pySim/ota.py:

  • Patch Set #2, Line 120:

    Looks like a spec ref is missing here? (TS 102 226 5.2.1 as it seems)

  • Patch Set #2, Line 323:

    I would recommend to add API docstrings for the other parameters, in particular the apdu parameter, which now can also be a list of APDUs.

  • Patch Set #2, Line 333:

    same here, I think we should document all parameters.

To view, visit change 43541. To unsubscribe, or for help writing mail filters, visit settings.