Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/33365 ) Change subject: transaction: move cc.codecs.remote -> cc.remote ...................................................................... Patch Set 1: (1 comment) Patchset: PS1:
Opening the debate here after looking at the whole patchset (I have no opinion but I think it's wort […] With audio codecs, the whole codec_filter (see include/osmocom/msc/codec_filter.h) code is based on "struct sdp_audio_codecs" which seems unsuitable for CSD:
``` struct sdp_audio_codec { /* Payload type number, like 3 for GSM-FR. */ unsigned int payload_type; /* Like "GSM", "AMR", "EFR", ... */ char subtype_name[16]; unsigned int rate; char fmtp[64]; }; ``` In CSD, SDP is the same for all bearer services (payload type 120, rate 8000, name CLEARMODE). For CSD we need to be able to have similar filter logic but based on bearer services (see struct csd_bs_map in src/libmsc/csd_bs.c in the last patch of this patchset). Therefore I implemented this bearer services logic separately. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33365 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I5d2e078db3b3437cb6feae40d8955912d7a297e4 Gerrit-Change-Number: 33365 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Tue, 20 Jun 2023 10:16:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin@sysmocom.de> Gerrit-MessageType: comment