Attention is currently required from: pespin.

View Change

1 comment:

• Patchset:

  • Patch Set #1:

    Opening the debate here after looking at the whole patchset (I have no opinion but I think it's wort […]

    With audio codecs, the whole codec_filter (see include/osmocom/msc/codec_filter.h) code is based on "struct sdp_audio_codecs" which seems unsuitable for CSD:

    ```
    struct sdp_audio_codec {
    	/* Payload type number, like 3 for GSM-FR. */
    	unsigned int payload_type;
    	/* Like "GSM", "AMR", "EFR", ... */
    	char subtype_name[16];
    	unsigned int rate;
    	char fmtp[64];
    };
    ```

    In CSD, SDP is the same for all bearer services (payload type 120, rate 8000, name CLEARMODE). For CSD we need to be able to have similar filter logic but based on bearer services (see struct csd_bs_map in src/libmsc/csd_bs.c in the last patch of this patchset). Therefore I implemented this bearer services logic separately.

To view, visit change 33365. To unsubscribe, or for help writing mail filters, visit settings.