Attention is currently required from: pespin. lynxis has posted comments on this change by lynxis. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43999?usp=email ) Change subject: tcap_as_loadshare: add TCAP IPA MT_TID_ACCEPT_NEW_TRAN ...................................................................... Patch Set 2: (5 comments) File src/ss7_asp.h: https://gerrit.osmocom.org/c/libosmo-sigtran/+/43999/comment/b7d1730f_8a7fd6... : PS2, Line 108: /* is this ASP is available for new TCAP sessions (Begin) */
"is this ASP available" or "Whether this ASP is available" Done
File src/ss7_asp.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/43999/comment/c6a55b2b_ba0068... : PS2, Line 782: #ifdef WITH_TCAP_LOADSHARING
I'd prefer having a default "prohibit_new_trans = false" or "new_incoming_trans_blocked" or similar, […] If you think it's more readable. I move the single line into a function.
File src/tcap_as_loadshare.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/43999/comment/41969130_078f15... : PS2, Line 985: goto out;
aren't we missing a Tx NACK here? yes, but actually we need to fix this in general.
https://gerrit.osmocom.org/c/libosmo-sigtran/+/43999/comment/35b3e66a_88dada... : PS2, Line 990: asp->tcap.enabled = true;
enabled should be done by ADD_RANGE like before imho? […] It depends how you would like to use this feature. IMHO: I can argue for both cases.
Do you want to have TCAP nodes without a range? Because with the trasaction tracking this also works. https://gerrit.osmocom.org/c/libosmo-sigtran/+/43999/comment/bc3cadfc_089903... : PS2, Line 993: LOGPASP(asp, DLTCAP, LOGL_INFO, "TCAP New transaction command: ASP will receive new TCAP transactions\n");
multiple lines Done
-- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43999?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Id4e7bb022a0c8b52369f6ded2729cf6cf8679556 Gerrit-Change-Number: 43999 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis <lynxis@fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Thu, 12 Nov 2026 13:12:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin@sysmocom.de>