Attention is currently required from: pespin.
5 comments:
File src/ss7_asp.h:
Patch Set #2, Line 108: /* is this ASP is available for new TCAP sessions (Begin) */
"is this ASP available" or "Whether this ASP is available"
Done
File src/ss7_asp.c:
Patch Set #2, Line 782: #ifdef WITH_TCAP_LOADSHARING
I'd prefer having a default "prohibit_new_trans = false" or "new_incoming_trans_blocked" or similar, […]
If you think it's more readable. I move the single line into a function.
File src/tcap_as_loadshare.c:
Patch Set #2, Line 985: goto out;
aren't we missing a Tx NACK here?
yes, but actually we need to fix this in general.
Patch Set #2, Line 990: asp->tcap.enabled = true;
enabled should be done by ADD_RANGE like before imho? […]
It depends how you would like to use this feature.
IMHO: I can argue for both cases.
Do you want to have TCAP nodes without a range? Because with the trasaction tracking this also works.
Patch Set #2, Line 993: LOGPASP(asp, DLTCAP, LOGL_INFO, "TCAP New transaction command: ASP will receive new TCAP transactions\n");
multiple lines
Done
To view, visit change 43999. To unsubscribe, or for help writing mail filters, visit settings.