Attention is currently required from: fixeria, neels, nt2mku, pespin.
jolly has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-msc/+/38197?usp=email )
Change subject: Remove speech codec list from bearer_cap for phase 1 mobile station ......................................................................
Patch Set 2:
(10 comments)
Commit Message:
https://gerrit.osmocom.org/c/osmo-msc/+/38197/comment/ca993d3b_0386790f?usp=... : PS1, Line 9: ect.
did you mean ext[ended]?
I mean octet 3a and all the possibly following codecs.
https://gerrit.osmocom.org/c/osmo-msc/+/38197/comment/38085e48_b6838253?usp=... : PS1, Line 16: ect.
did you mean ext[ended]?
I mean octet 3a and all the possibly following codecs.
File src/libmsc/gsm_04_08_cc.c:
https://gerrit.osmocom.org/c/osmo-msc/+/38197/comment/0896b3ea_61c80a4f?usp=... : PS1, Line 929: /* Remove codecs in bearer_cap that are unsupported by phase 1 mobile stations.
It probably makes sense to move this to a helper function, eg […]
Done
https://gerrit.osmocom.org/c/osmo-msc/+/38197/comment/69657754_189e2994?usp=... : PS1, Line 990: /* Speech codec list (oictets 3a ect.) must not be sent to phase 1 mobile stations.
octets
Done
https://gerrit.osmocom.org/c/osmo-msc/+/38197/comment/3d072922_cd5121e1?usp=... : PS1, Line 992: if (trans->vsub->classmark.classmark1.rev_lev == 0)
I guess you could do this in the GSM48_BCAP_ITCAP_SPEECH code path above?
Done
https://gerrit.osmocom.org/c/osmo-msc/+/38197/comment/9cf72a70_fd7cca58?usp=... : PS1, Line 1158: /* Speech codec list (oictets 3a ect.) must not be sent to phase 1 mobile stations.
octets
Done
https://gerrit.osmocom.org/c/osmo-msc/+/38197/comment/78e0e9dd_5f7d82f2?usp=... : PS1, Line 1878: /* Speech codec list (oictets 3a ect.) must not be sent to phase 1 mobile stations.
octets
Done
https://gerrit.osmocom.org/c/osmo-msc/+/38197/comment/6e7a2dd8_4c4ef68c?usp=... : PS1, Line 1930: /* Speech codec list (oictets 3a ect.) must not be sent to phase 1 mobile stations.
octets
Done
https://gerrit.osmocom.org/c/osmo-msc/+/38197/comment/aab4fb6e_a108045d?usp=... : PS1, Line 1988: /* Speech codec list (oictets 3a ect.) must not be sent to phase 1 mobile stations.
octets
Done
https://gerrit.osmocom.org/c/osmo-msc/+/38197/comment/f1d55bd2_dce0c7b1?usp=... : PS1, Line 1991: modify->bearer_cap.speech_ver[0] = -1;
I see this being done in lots of places, it may make sense to move the logic to a helper function to […]
Done