Attention is currently required from: fixeria, neels, nt2mku, pespin.

View Change

10 comments:

• Commit Message:

  • Patch Set #1, Line 9: ect.

    did you mean ext[ended]?

    I mean octet 3a and all the possibly following codecs.

  • Patch Set #1, Line 16: ect.

    did you mean ext[ended]?

    I mean octet 3a and all the possibly following codecs.

• File src/libmsc/gsm_04_08_cc.c:

  • Patch Set #1, Line 929: /* Remove codecs in bearer_cap that are unsupported by phase 1 mobile stations.

    It probably makes sense to move this to a helper function, eg […]

    Done

  • Patch Set #1, Line 990: /* Speech codec list (oictets 3a ect.) must not be sent to phase 1 mobile stations.

    octets

    Done

  • Patch Set #1, Line 992: if (trans->vsub->classmark.classmark1.rev_lev == 0)

    I guess you could do this in the GSM48_BCAP_ITCAP_SPEECH code path above?

    Done

  • Patch Set #1, Line 1158: /* Speech codec list (oictets 3a ect.) must not be sent to phase 1 mobile stations.

    octets

    Done

  • Patch Set #1, Line 1878: /* Speech codec list (oictets 3a ect.) must not be sent to phase 1 mobile stations.

    octets

    Done

  • Patch Set #1, Line 1930: /* Speech codec list (oictets 3a ect.) must not be sent to phase 1 mobile stations.

    octets

    Done

  • Patch Set #1, Line 1988: /* Speech codec list (oictets 3a ect.) must not be sent to phase 1 mobile stations.

    octets

    Done

  • Patch Set #1, Line 1991: modify->bearer_cap.speech_ver[0] = -1;

    I see this being done in lots of places, it may make sense to move the logic to a helper function to […]

    Done

To view, visit change 38197. To unsubscribe, or for help writing mail filters, visit settings.