Attention is currently required from: laforge, neels.
dexter has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/40198?usp=email )
Change subject: personalization: implement reading back values from a PES ......................................................................
Patch Set 13: Code-Review+2
(4 comments)
Patchset:
PS13: To me everything looks fine here.
File pySim/esim/saip/personalization.py:
https://gerrit.osmocom.org/c/pysim/+/40198/comment/defadd47_8d597171?usp=ema... : PS11, Line 292: if isinstance(val, bytes):
the values are coming from a ProfileElementSequence's decoded section, should always be either a hex […]
I think everything is fine here. (I now know that the code uses bytes and hexstrings for parameters.)
https://gerrit.osmocom.org/c/pysim/+/40198/comment/4480cc7e_385b26a5?usp=ema... : PS11, Line 297: val = unrpad(val, c)
I got this code from elsewhere (or reversing code from elsewhere?) […]
Ah ok. So "4141" => "AA" is indeed what you want. Then everything is fine.
File pySim/esim/saip/personalization.py:
https://gerrit.osmocom.org/c/pysim/+/40198/comment/79fa47ec_fb919824?usp=ema... : PS13, Line 410: acc_f = pe.files.get('ef-acc', None) Apparently we are doing nothing with acc_f but I can see that in the following patch acc_f is used. If you want to make it perfect you could move this line into the correct patch, but I think it is not necessary.