Attention is currently required from: laforge, neels.

Patch set 13:Code-Review +2

4 comments:

Patchset:
- Patch Set #13:
  To me everything looks fine here.
File pySim/esim/saip/personalization.py:
- Patch Set #11, Line 292: if isinstance(val, bytes):
  the values are coming from a ProfileElementSequence's decoded section, should always be either a hex […]
  I think everything is fine here. (I now know that the code uses bytes and hexstrings for parameters.)
- Patch Set #11, Line 297: val = unrpad(val, c)
  I got this code from elsewhere (or reversing code from elsewhere?) […]
  Ah ok. So "4141" => "AA" is indeed what you want. Then everything is fine.
File pySim/esim/saip/personalization.py:
- Patch Set #13, Line 410: acc_f = pe.files.get('ef-acc', None)
  Apparently we are doing nothing with acc_f but I can see that in the following patch acc_f is used. If you want to make it perfect you could move this line into the correct patch, but I think it is not necessary.

To view, visit change 40198. To unsubscribe, or for help writing mail filters, visit settings.