Hi Gianni, On Thu, May 12, 2011 at 03:27:15AM +0100, Gianni Tedesco wrote:
Attached patch implements SMS decoding.
are you aware that we already have 7bit decoding routines in libosmogsm, as well as other SMS parsing code in OpenBSC? I would prefer if we have one implementation that is in the shared library and re-used by all the various Osmocom projects. Maybe the existing routines are not suitable right-away, then they should be adapted. But two implementations for the same task doesn't sound like a good solution to me. Thanks! -- - Harald Welte <laforge@gnumonks.org> http://laforge.gnumonks.org/ ============================================================================ "Privacy in residential applications is a desirable marketing option." (ETSI EN 300 175-7 Ch. A6)