21 Feb
2012
21 Feb
'12
4:55 p.m.
Patch looks fine to me,
On Tue, Feb 21, 2012 at 03:32:34PM +0100, Tim Ehlers wrote:
int telnet_init(void *tall_ctx, void *priv, int
port)
{
+ int rc;
+ rc = telnet_init_dynif(tall_ctx, priv, "127.0.0.1", port);
+
+ return rc;
+}
erm, as far as I can tell, there's no point in having the rc variable,
it could simply be "return telnet_init_dynif(...)".
- sock_addr.sin_addr.s_addr = htonl(INADDR_LOOPBACK);
+ sock_addr.sin_addr.s_addr = inet_addr(ip);
This is still ipv4-only and not using the libosmocore/socket.c code as I
suggested. However, I think we can first merge your current patch.
Hoepfully somebody can contribute a conversion to libosmocore/socket.c
API, which would automatically make ipv6 work, too.
I'm currently travelling and don't have time to test it right now. I
home one of the other developers with commit access will be able to try
it.
Thanks.
Regards,
Harald
--
- Harald Welte <laforge(a)gnumonks.org> http://laforge.gnumonks.org/
============================================================================
"Privacy in residential applications is a desirable marketing option."
(ETSI EN 300 175-7 Ch. A6)