14 Jan
2018
14 Jan
'18
7:35 p.m.
On Sun, Jan 14, 2018 at 11:40:30PM +0600, Vadim Yanitskiy wrote:
fine with me.
The mentioned logging related symbols are not
installed:
ok, thanks.
I suggest you
simply rebase your chain of commits on current
master and push it into gerrit.
But this way, each commit of the whole chain would require +2
and V+1, because 'make check' was implemented at the end of
the chain. What if I merge 'fixeria/lib' into a local
'master' and send
it for review? I think, this would be simpler. Or would this
anyway send the whole chain to review? :)
I don't really know what gerrit does in case of merges, as we don't
generally use merges much but prefer a linear history. You could try,
if you're interested.
In any case, let's wait and see what Sylvain says regarding the code
--
- Harald Welte <laforge(a)gnumonks.org> http://laforge.gnumonks.org/
============================================================================
"Privacy in residential applications is a desirable marketing option."
(ETSI EN 300 175-7 Ch. A6)