On Thu, Nov 24, 2011 at 07:58:33AM +0100, Sylvain Munaut wrote:
Hi,
First, thanks for this series of patch, I'll be sure to review and test them.
Well, no problem, I had some time on hand I couldn't use otherwise.
this
eliminates the occurrance of gcc warning
warning: cast increases required alignment of target type
---
src/target/firmware/include/comm/timer.h | 4 +++-
src/target/firmware/include/layer1/sched_gsmtime.h | 5 ++++-
2 files changed, 7 insertions(+), 2 deletions(-)
-};
+} __packed;
I'm not conviced by this one : Why should we use packed for structures
not used as 'communication packets' ?
What are the drawbacks ?
Steve and Holger raised some reasonable concerns on some of the other
patches, it seems I was quite unconcentrated and they are mostly crap.
The patches do not contain any "magic" anyway. Just straight-forward
reaction on the different kind of warnings. Most of them can be
eliminated easily.
Kind regards
-Alex