Re: gr-osmosdr build issue (patch included)

(I would just get rid of "register" and not "const" as well) P On Mon, Jun 20, 2022 at 04:41:20AM +0200, Stefan Oltmanns wrote: > Hello, > > gr-osmosdr currently doesn't build on macOS (probably not with clang in > general), because C++17 does not allow the "register storage class > specifier". > > The fix is quite trivial: > > --- a/lib/hackrf/hackrf_sink_c.cc > +++ b/lib/hackrf/hackrf_sink_c.cc > @@ -299,7 +299,7 @@ void convert_avx(const float* inbuf, int8_t* > outbuf,const unsigned int count) > #elif USE_SSE2 > void convert_sse2(const float* inbuf, int8_t* outbuf,const unsigned > int count) > { > - const register __m128 mulme = _mm_set_ps( 127.0f, 127.0f, 127.0f, > 127.0f ); > + __m128 mulme = _mm_set_ps( 127.0f, 127.0f, 127.0f, 127.0f ); > __m128 itmp1,itmp2,itmp3,itmp4; > __m128i otmp1,otmp2,otmp3,otmp4; > > Could you please apply that patch and also create a new release? > Unfortunately gr-osmosdr was thrown out of the homebrew package earlier > this year, because it didn't build. > I would like to get it back in, because that would make things on mac a > lot easier (and GNURadio tutorials for mac would be correct again and > not cause frustration). > > I assume the easiest way to get it back in is to have a new official > release that builds again correctly. > > Best regards > Stefan