Hi Alexander,
On Thu, 2014-03-27 at 09:21, Alexander Chemeris wrote:
On Thu, Mar 27, 2014 at 2:30 AM, Daniel Willmann
<dwillmann(a)sysmocom.de> wrote:
+Testing gsm340_scts(gsm340_gen_scts(ts)) == ts
for TZ UTC
+Testing gsm340_scts(gsm340_gen_scts(ts)) == ts for TZ Europe/London
+1364691600 -> 31301310000000 -> 1364695200
+Timezone Europe/London failed at ts 1364691600
A quick question - why does it says "failed" here?
If it's ok, than we should change the wording of the message, I think.
If it's not ok, we should not add this to "sms_test.ok". Right now
it's confusing.
you're right. I was trying to first record the status quo so you can see
the behaviour changes as the issue is fixed.
Holger was quite fond of this in the recent lapdm fixes, but it probably
makes less sense here. Holger, any preferences how I should handle this?
Move the test to the end, have a failing test, ..?
Regard,
Daniel
--
- Daniel Willmann <dwillmann(a)sysmocom.de>
http://www.sysmocom.de/
=======================================================================
* sysmocom - systems for mobile communications GmbH
* Schivelbeiner Str. 5
* 10439 Berlin, Germany
* Sitz / Registered office: Berlin, HRB 134158 B
* Geschaeftsfuehrer / Managing Directors: Holger Freyther, Harald Welte