docker-playground to gerrit?
Do I have permission to move the docker-playground.git to gerrit? I have a bunch of patches already in my various branches. I could just push them onto master, but I guess some code review would be good? Should we also add a gerrit job that tests the changes? Kind of hard to make a failure decision though while when some tests are normally failing, like they still are. ~N
Hi Neels, On Fri, Mar 16, 2018 at 03:11:08AM +0100, Neels Hofmeyr wrote:
Do I have permission to move the docker-playground.git to gerrit? I have a bunch of patches already in my various branches. I could just push them onto master, but I guess some code review would be good?
Go ahead.
Should we also add a gerrit job that tests the changes?
One could test whether the individual Dockerfiles still build. ("docker build"). -- - Harald Welte <laforge@gnumonks.org> http://laforge.gnumonks.org/ ============================================================================ "Privacy in residential applications is a desirable marketing option." (ETSI EN 300 175-7 Ch. A6)
participants (2)
-
Harald Welte -
Neels Hofmeyr