Dear Holger,
I just wanted to ask if you pleased with the patch or not? I just wanted to make sure that
this part is fixed and code quality is OK by you, so I can move on to the next one.
Regards,
Csaba
----- Továbbított üzenet -----
Feladó: "Sipos Csaba" <sipos.csaba(a)kvk.uni-obuda.hu>
Címzett: "Holger Hans Peter Freyther" <holger(a)freyther.de>
Másolatot kap: openbsc(a)lists.osmocom.org
Elküldött üzenetek: Szerda, 2015. Február. 4. 13:12:34
Tárgy: Re: Patch for OpenBSC [Nokia Site family]
Dear Holger,
I think I found a better way for initialization. The attached version of the patch builds
against latest master OpenBSC, contains the fixes I missed from the previous version.
Tested:
1. Without using the config parameter, the reset timer defaults to 15 seconds (as
before),
2. With the configuration parameter, the reset timer will use the specified value.
Tested with: InSite (daisy chained, two BTSes), MetroSite and UltraSite units.
Will create another patch for hopping (both baseband and sytheiser hopping works, but it
needs a change in the sourcecode, like the reset timer before).
There is another minor problem at the moment: UltraSite needs additional time after OMU
configuration done, before it can bootstrap the RSL links. This is due to the fact that
UltraSite starts to load the TRX SW after it got the "Use current" command, and
it takes arouned 45-50 seconds for the TRXes to be ready for LAPD. So to first RSL
bootstrap should be delayed after OMU config complete is received by the BSC. Now the RSL
link is bootstrapped right after the OMU is configured and the LAPD link times out way
before the TRX will be ready for LAPD. Will try to create a patch for this too, until
then, a small hack can make this problem go away (changing n200 parameter to 100).
Regards,
Csaba
----- Eredeti üzenet -----
Feladó: "Holger Hans Peter Freyther" <holger(a)freyther.de>
Címzett: "Sipos Csaba" <sipos.csaba(a)kvk.uni-obuda.hu>
Elküldött üzenetek: Hétfő, 2015. Február. 2. 9:50:50
Tárgy: Re: Patch for OpenBSC [Nokia Site family]
On Sun, Feb 01, 2015 at 10:53:19PM +0100, Sipos Csaba wrote:
Can you please tell me where should I initialize the
timer, when the config parameter is not used (user not specified it in the cfg file)?
I tried to look at other parts of the code but I don't see where the default values
are stored, if a parameter is not set in the config file.
Otherwise I fixed the remaining problems.
It is not the best place but gsm_bts_alloc would allow you to
initialize this field correctly. The other option would be when
the type of the bts is set to nokia.