Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/3324/1/src/osmo_client_network.c
File src/osmo_client_network.c:
Line 165: if (src)
Why not src_result directly?
because it's
not initialized with NULL, so we cannot check if it contains random chunk or valid data.
Hence I used the same condition that you use before getaddrinfo().
--
To view, visit
https://gerrit.osmocom.org/3324
To unsubscribe, visit
https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3b6778d9110583ecb1daec59ef2c86465d5818b9
Gerrit-PatchSet: 1
Gerrit-Project: osmo-pcap
Gerrit-Branch: master
Gerrit-Owner: Harald Welte <laforge(a)gnumonks.org>
Gerrit-Reviewer: Harald Welte <laforge(a)gnumonks.org>
Gerrit-Reviewer: Holger Freyther <holger(a)freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: Yes