Patch Set 1: (3 comments) https://gerrit.osmocom.org/#/c/70/1/src/vty/stats_vty.c File src/vty/stats_vty.c: Line 362: struct vty *vty = sctx_;
I think you will not find another place with a '_' as suffix to a parameter No idea what's the semantic, but I did it similiar to http://git.osmocom.org/libosmocore/tree/src/stats.c#n479
Line 363: const char *description = counter->description ? counter->description : "";
Have you encountered counters without a description? yes. `struct osmo_counter` doesn't have one.
Line 397: description,
For XML there is something like xml_escape. Do we need (and can we) escape we can escape those by backslashes. Do we need this to do it right now? http://www.methods.co.nz/asciidoc/faq.html#_how_can_i_escape_asciidoc_markup
-- To view, visit https://gerrit.osmocom.org/70 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia8af883167e5ee631059299b107ea83c8bbffdfb Gerrit-PatchSet: 1 Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Owner: lynxis lazus <lynxis@fe80.eu> Gerrit-Reviewer: Holger Freyther <holger@freyther.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis@fe80.eu> Gerrit-HasComments: Yes