On Mon, Jul 8, 2013 at 11:44 PM, Peter Stuge <peter@stuge.se> wrote:
Harald Welte wrote:
We can establish:
* Andreas should have run 'make check' before asking me to merge * I should have run 'make check' ahead of the commit and not immediately after ;) My apologies for that. .. So as a result, we introduce a new rule / process:
Maybe consider running 'make check' in a pre-receive hook on the server.
I'm a big fan of Gerrit because it allows such verification to run asynchronously after a push. Gerrit sits between the developer and the official git repository. Everybody pushes to Gerrit, not to the actual repo. (Yes, when using a workflow that depends on gitolite or gitosis access control becomes an issue with Gerrit.)
+1. It has much nicer interface for review as well. -- Regards, Alexander Chemeris. CEO, Fairwaves LLC / ООО УмРадио http://fairwaves.ru