Re: [PATCH 1/4] gprs_gmm: ensure llme present upon Attach Req (CID #57686)

On 14 Apr 2016, at 15:21, Neels Hofmeyr <nhofmeyr@sysmocom.de> wrote:

--- openbsc/src/gprs/gprs_gmm.c | 4 ++++ 1 file changed, 4 insertions(+)

diff --git a/openbsc/src/gprs/gprs_gmm.c b/openbsc/src/gprs/gprs_gmm.c index 5f0a5fd..438e047 100644 --- a/openbsc/src/gprs/gprs_gmm.c +++ b/openbsc/src/gprs/gprs_gmm.c @@ -838,6 +838,10 @@ static int gsm48_rx_gmm_att_req(struct sgsn_mm_ctx *ctx, struct msgb *msg, int rc;

LOGMMCTXP(LOGL_INFO, ctx, "-> GMM ATTACH REQUEST "); + if (!llme) {

same as with my other mail. The lower layer should create a llme on the fly. So please have a look at the coverity user interface to see _where_ the llme is NULL and then we can have a look at that issue. holger