On Wed, Feb 24, 2016 at 10:08:35AM +0100, Harald Welte wrote:
Hi Neels,
On Wed, Feb 24, 2016 at 03:39:39AM +0100, Neels Hofmeyr wrote:
L_NS_NODE, /*!< \brief NS node in
libosmo-gb. */
L_BSSGP_NODE, /*!< \brief BSSGP node in libosmo-gb. */
+ CTRL_NODE, /*!< \brief Control interface node. */
+
the existing nodes are pre-fixed with L_ to indicate they are part of a
library, as opposed to those without prefix (from the main application).
AFAICT it is used only in openbsc, but still the control interface itself
is part of libosmocore. That's why I put its vty there in the first place.
libosmocore/src/ctrl/* -- Am I missing something?
While we're at it:
I'd have put CTRL_NODE above but that would shift the numbers of the L_*
items.
I find the name CTRL_NODE a bit too general. e.g. we also have Ctrl in
GTP. First I had CTRLIFACE_NODE, but most other control interface code
uses the ctrl_ prefix and that looks ugly too. Any opinions?
~Neels