9 May
2017
9 May
'17
12:46 p.m.
On Tue, May 09, 2017 at 07:06:27AM +0200, Harald Welte wrote:
Hi Neels,
On Tue, May 09, 2017 at 12:15:12AM +0200, Neels Hofmeyr wrote:
And call it "vtython" from python :)
I indeed would prefer that from the implicit exiting. Hoping that most
users would anyway have properly indented config files...
On the telnet vty, we can so far also issue commands that belong to the
parent and end up on the parent level implicitly, which we would also stop
with this change; I think that'd be a good thing.
The code would be slightly non-trivial, simply counting the number of
spaces leading each line, and issue an exit for every decrease is not
enough: we need to count the number of de-indentings to exit multiple
times e.g. at the end of net/bts/trx. I guess we should count tabs as
single indents, but make sure that a config file has only tabs or only
spaces, not a mixture? count tabs as eight? disallow tabs altogether?
Otherwise we could look at how python solves that and maybe copy their
code over to C... which would probably be quite complex.
~N
About 2: we tend to indent our VTY config files,
but in fact the indentation
has no effect whatsoever, it is just eye candy (very useful eye candy).
Maybe we should change that part, rather than renaming commands for no
good reason? We could use the indent level to generate 'virtual node
exit' commands...