On 03/17/2016 03:50 PM, Holger Freyther wrote:
On 17 Mar 2016, at 11:51, msuraev@sysmocom.de wrote:
+struct earfcn { + /* EARFCN (16 bits) array */ + uint16_t *arfcn;
Who do you write the comments for? If for a developer, have you checked they turn up in doxygen?
For myself mostly.
+ bool thresh_lo_valid; this breaks the osmo-bts build:
http://jenkins.osmocom.org/jenkins/job/osmo-bts/2029/
In file included from sysinfo.c:23: /home/builder/source/workspace/osmo-bts/FIRMWARE_VERSION/master/label/linux_i386_debian_squeeze/deps/libosmocore/../install/include/osmocom/gsm/sysinfo.h:56: error: expected specifier-qualifier-list before 'bool'
Fixed in "Fix earfcn struct header" patch. -- Max Suraev <msuraev@sysmocom.de> http://www.sysmocom.de/ ======================================================================= * sysmocom - systems for mobile communications GmbH * Alt-Moabit 93 * 10559 Berlin, Germany * Sitz / Registered office: Berlin, HRB 134158 B * Geschaeftsfuehrer / Managing Directors: Holger Freyther, Harald Welte