Hi,
We should add another point into the discussion. Who and how are going
to test these changes?
If I understand correctly code from Omar is rebased on top of current
osmo-bts master, and has been tested at least in some general scenarios?
If that's the case, it probably makes sense to merge them as it is now,
and then either or both:
* Do the refactoring and ask someone with an OC-2G to test again after
refactoring
* Add automatic testing for OC-2G to make sure we don't break stuff
** Add support for OC-2G in osmo-gsm-tester
** Add support for OC-2G in TTCN3(+osmo-gsm-tester)
Once it's merged, we can create a ticket with information from your
e-mail on how to do the refactor.
Regards,
Pau
--
- Pau Espin Pedrol <pespin(a)sysmocom.de>
http://www.sysmocom.de/
=======================================================================
* sysmocom - systems for mobile communications GmbH
* Alt-Moabit 93
* 10559 Berlin, Germany
* Sitz / Registered office: Berlin, HRB 134158 B
* Geschaeftsfuehrer / Managing Director: Harald Welte