Re: [PATCH 5/6] osmux: Enforce Osmux only global and per BSC configuration

On 05 Oct 2015, at 12:37, Neels Hofmeyr <nhofmeyr@sysmocom.de> wrote:

On Sun, Oct 04, 2015 at 11:22:53AM +0200, Holger Hans Peter Freyther wrote:

...

+ /* If we require osmux and it is not disabled.. fail */ + if (nat_osmux_only(bsc->nat->mgcp_cfg, bsc->cfg) && + endp->osmux.state == OSMUX_STATE_DISABLED) { [...]

Comment: If we require osmux and it IS disabled, fail

That's the only thing I spotted in your patch series.

thanks!