17 Mar
2016
17 Mar
'16
5:34 p.m.
On 17 Mar 2016, at 17:21, Вадим Яницкий
<axilirator(a)gmail.com> wrote:
Hi Guys!
yes, we have a schema version and can just increase it. E.g. have a look at how we migrate
SMS.
If you have time, please check if there are other
occurrences in OpenBSC
or OsmocomBB where the TMSI is printed as integer. Thanks!
No problem! :)
I think it was a bit too quick. I foresee one
problem. Let's assume someone
is using TMSIs and now upgrade the sourcecode. All CM Service Requests
will fail because the TMSI is not known. What is the migration/mitigation plan?
I absolutely agree with Holger. Maybe we can add some code that will check
if database still stores TMSIs in old representation style and convert them to
uint32_t? We can change the libmsc/db.c:db_prepare() for this purpose. tmsi_from_string will not work for this anymore.
Yes, I forgot to change the gsm_subscriber.c ... Sorry. there is no length check but that doesn't
seem to be a big issue right now.
We can just write a function that will do this check instead of using #define. * a DB schema upgrade and store the TMSI as
uint32_t
* Use hex presentation in VTY
+1