8 Sep
2017
8 Sep
'17
1:11 p.m.
On 07.09.2017 21:04, Harald Welte wrote:
But then, I guess we have more important work than to
refactor something that has
worked for more than 5 years :/
Just to make sure we won't forget the details in 5 years I've created
https://osmocom.org/issues/2508.
I think it could be done at any time, osmo-bsc.git is ready.
Unfortunately not. The OsmoBSC headers were renamed to
".../bsc/gsm_data_shared.h"
while OsmoBTS explicitly requires "openbsc/gsm_data_shared.h". So it's
impossible to
build OsmoBTS against OsmoBSC ATM.
One option would be to include just "gsm_data_shared.h" (without directories)
in
OsmoBTS and use "--with-openbsc=" configure option but I have not looked in
detail
how much breaks in other places it might cause. Simpler option would be to switch to
new "bsc/gsm_data_shared.h" but it would make it incompatible with legacy
OpenBSC
which is still in use in some deployments. We can also add symlink with old name to
OsmoBSC as a temporary workaround until the refactoring for #2508 will take place.
I'm somewhat reluctant to just copy "gsm_data_shared.h" to OsmoBTS as it
might
introduce all sorts of problems when OpenBSC and OsmoBSC diverge but it might be an
option too.
What do you think?
--
Max Suraev <msuraev(a)sysmocom.de> http://www.sysmocom.de/
=======================================================================
* sysmocom - systems for mobile communications GmbH
* Alt-Moabit 93
* 10559 Berlin, Germany
* Sitz / Registered office: Berlin, HRB 134158 B
* Geschaeftsfuehrer / Managing Director: Harald Welte