Patch Set 1:
all checks of (this == null) will be eliminated by GCC >= 6.1
(
https://gcc.gnu.org/gcc-6/changes.html, Value range propagation now assumes that the this
pointer of C++ member functions is non-null. This eliminates common null pointer checks
but also breaks some non-conforming code-bases (such as Qt-5, Chromium, KDevelop). As a
temporary work-around -fno-delete-null-pointer-checks can be used. Wrong code can be
identified by using -fsanitize=undefined.)
But given the "make check" failure we seem to expect that. You will need to move
the null check before calling the function or create a method wrapper where the tbf
pointer is passed so we can do the null check there.
--
To view, visit
https://gerrit.osmocom.org/136
To unsubscribe, visit
https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifddaef70bb0a4402050c817b1000d515c3a7118b
Gerrit-PatchSet: 1
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Harald Welte <laforge(a)gnumonks.org>
Gerrit-Reviewer: Holger Freyther <holger(a)freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Gerrit-HasComments: No