Hi Neels, On Mon, Nov 23, 2015 at 03:02:08PM +0100, Neels Hofmeyr wrote:
About below commit: Sorry / Thanks! I forgot to move gtphub into the HAVE_LIBCARES conditional when I added ares...
No problem. It's easy to miss such conditional build topics without automatic testing (hint!). It might make sense to have a few chroot() environments with and without those libraries installed and test the builds. Also, it would be good to have some documentation on the build requirements / conditionals in the README file.
But does it make sense to enable the gtphub test when the binary isn't built?
No, we can skip that. -- - Harald Welte <laforge@gnumonks.org> http://laforge.gnumonks.org/ ============================================================================ "Privacy in residential applications is a desirable marketing option." (ETSI EN 300 175-7 Ch. A6)