Hi,
On 10/24/2013 08:28 AM, Holger Hans Peter Freyther wrote:
On Wed, Oct 23, 2013 at 11:24:18AM +0200, Jacob
Erlbeck wrote:
All patches look fine but the semantic is odd here
+gDEFUN(delete_gb_bvci, delete_gb_bvci_cmd,
+ "delete-gbproxy-peer <0-65534> bvci <2-65534>",
+ "Delete a GBProxy peer by NSEI and optionally BVCI\n"
"NSEI number\n"
- "BVCI\n"
+ "Only delete peer with a matching BVCI\n"
"BVCI number\n")
delete-gbproxy-peer 1 bvci 3 show. Better either improve the
existing show command or create a new one. :)
I expected this remark ;-) I'm not really happy with this either. I had
something in mind like a dry-run option. I decided against an additional
show command since this 'show' is tightly coupled to the peer selection
of the 'delete-gbproxy-peer'. That's less obvious, when a different
command is used.
What do you think about an optional final '[dry-run]' instead of the
'show'?
Jacob