Re: [PATCH 3/3] nitb/ctrl: Add ctrl command to get/set arfcn

On Tue, May 06, 2014 at 07:35:59PM +0400, Ivan Kluchnikov wrote: Hi again, Please look at cfg_trx_arfcn_cmd in src/libbsc/bsc_vty.c. There are plenty of "FIXME" in the code and they all apply here. There are two separate issues that your patch is touching. 1.) Align VTY and CTRL command. My approach so far was to move the "handling" into a common method that is used by CTRL/VTY. 2.) The general question of "when" to apply the configuration. For some commands it is immediate, for some comments it is after a BTS is bootstrapped again and for some it requires a re-start of the NITB application. 3.) Make it impossible to configure a "broken" system. For your code and the VTY command it is possible to create and later save/write a config that will not be parsed on re-start. So this patch at least needs to do: * Make the CTRL and VTY share a routine to "set" the ARFCN * Move the FIXMEs into this routine * Verify that the BAND + ARFCN would be compatible (so we would still have three FIXMEs left). cheers holger