Yes, with estimate set to true it does not change anything - only computes number of necessary bits. I'll send updated patch later on. On 03/16/2016 11:26 AM, Harald Welte wrote:
Hi Max,
On Tue, Mar 15, 2016 at 02:51:08PM +0100, msuraev@sysmocom.de wrote:
+ * \param[in] estimate indicates whether to return number of bits required + * instead of actually changing bv is it actually just estimating (i.e. taking a guess) of how many bits were needed, or is it actually computing a definitive amount of output bits?
Also, I would prefer to call it 'estimate_ownly' or 'determine_bits_only'. Or even something like 'dry_run', which is used a lot in command-line arguments to indicate that it will not actually perform the operation.
-- Max Suraev <msuraev@sysmocom.de> http://www.sysmocom.de/ ======================================================================= * sysmocom - systems for mobile communications GmbH * Alt-Moabit 93 * 10559 Berlin, Germany * Sitz / Registered office: Berlin, HRB 134158 B * Geschaeftsfuehrer / Managing Directors: Holger Freyther, Harald Welte