Re: [libosmo-dsp PATCH 5/5] build: avoid running unused checks

Il 04/07/2012 13:52, Sylvain Munaut ha scritto: There is, but I don't think that's a very good idea. Basically what happens is that if the headers are not present, both before and after this patch, the build will fail — and it's much easier if you're porting to an OS/combination to fix the issue if you get a build failure than a configure failure (especially because often times the configure checks end up bitrotting). If you add a failure condition on the configure script, what you get is a longer ./configure time on all systems (compared to after my patch) and the same kind of build failure, just telling you that a header file is missing. My suggestion is to avoid all kind of checks that would be fatal unless they can be overridden (like the pkg-config checks), or there is a fallback available. Also if there is a fallback available I suggest using a fallback-style check, like the one I describe at http://goo.gl/OAxBt . -- Diego Elio Pettenò — Flameeyes flameeyes(a)flameeyes.eu — http://blog.flameeyes.eu/