From Vadim Yanitskiy <axilirator@gmail.com>:
Vadim Yanitskiy has posted comments on this change. Change subject: db.c: implemented incremental migration ...................................................................... Patch Set 1: (1 comment)
(2 comments)
Could you please add a test db with version 1 preferable and "test" the migration? IIRC we already one case for the SMS conversion I did a couple of years ago.
I have already tested migration process from 3 to 5. Maybe it would be better to do in another commit? We can name it "db.c: implemented update_db_revision_1()" or such. What do you thik about it? https://gerrit.osmocom.org/#/c/62/1/openbsc/src/libmsc/db.c File openbsc/src/libmsc/db.c: Line 412: goto error;
For coverity we will most likely need to add a "fallthrough" comment or suc Should I add this comment before every 'case' statement? Or just replace the 'waterfall' by 'fallthrough'?
-- To view, visit https://gerrit.osmocom.org/62 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia9c2aa86f96b88ad8a710d0a23879ce219bc82dc Gerrit-PatchSet: 1 Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Owner: Vadim Yanitskiy <axilirator@gmail.com> Gerrit-Reviewer: Holger Freyther <holger@freyther.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy <axilirator@gmail.com> Gerrit-HasComments: Yes