12 Aug
2021
12 Aug
'21
6 a.m.
Hi Neels,
On 8/2/21 12:06 AM, Neels Hofmeyr wrote:
Just now I came across this code,
with an early return in case of BCCH. But right below that, BCCH is still
mentioned in the comment, and there are more IEs being parsed.
So I get the impression the early return may prevent that OSMO_MIN limiting for
BCCH, and that may not be intended?
in rsl_rx_bs_pwr_ctrl(), we actually handle these different cases:
a) power reduction on *inactive* logical channels of the BCCH carrier,
b) power reduction on *active* logical channels of the BCCH carrier,
c) power reduction on *active* logical channels of a non-BCCH carrier.
Case a) is handled in bts_set_c0_pwr_red(). This function iterates over
all timeslots and sets power reduction values depending on their pchan
combinations.
Case b) actually depends on a), because ts->c0_power_red_db is set in
bts_set_c0_pwr_red(). The idea is that b) is not allowed unless the BTS
is operating in the power saving mode.
So, this is why the OSMO_MIN limiting is not relevant to a).
Case c) is not related to the question brought in this thread.
Regards,
Vadim.
--
- Vadim Yanitskiy <vyanitskiy at sysmocom.de> http://www.sysmocom.de/
=======================================================================
* sysmocom - systems for mobile communications GmbH
* Alt-Moabit 93
* 10559 Berlin, Germany
* Sitz / Registered office: Berlin, HRB 134158 B
* Geschaeftsfuehrer / Managing Director: Harald Welte