I think autogenerated files should be removed from git and created during build time. See for example 84da22f96429f77276783d28622d0c6acb5c484d in libosmocore. This helps to ensure "single source of truth" - everybody using the same place to make changes instead of accidentally changing the file which will be overwritten by .py script next time. On 05/23/2016 12:47 PM, Neels Hofmeyr wrote:
This patch has been merged last week, but...
On Sun, May 15, 2016 at 11:44:10AM +0000, gerrit-no-reply@lists.osmocom.org wrote:
--- a/include/osmocom/ranap/ranap_ies_defs.h +++ /dev/null @@ -1,2967 +0,0 @@ -/******************************************************************************* - * This file had been created by asn1tostruct.py script v0.5osmo1 - * Please do not modify this file but regenerate it via script. - * Created on: 2016-02-19 16:51:41.625903 by daniel - * from ['../asn1//ranap/RANAP-PDU-Contents.asn'] - ******************************************************************************/ -#include <osmocom/ranap/ranap_common.h> - I assumed we wanted the ranap_ies_defs.h file to be committed. It is generated automatically, yes, but IMHO it is a good idea to track the changes in the generated code.
By having a gen_ranap.stamp, every clean checkout would first regenerate the ranap_ies_defs.h. That would generally be fine to verify that we still have the same ranap_ies_defs.h, except for the comment on top:
* Created on: 2016-02-19 16:51:41.625903 by daniel
If re-adding the ranap_ies_defs.h to git, we'd also want to drop generation of that line from the py script and leave the change tracking up to git.
Am I making sense or should I just drop this?
~Neels
-- Max Suraev <msuraev@sysmocom.de> http://www.sysmocom.de/ ======================================================================= * sysmocom - systems for mobile communications GmbH * Alt-Moabit 93 * 10559 Berlin, Germany * Sitz / Registered office: Berlin, HRB 134158 B * Geschaeftsfuehrer / Managing Directors: Holger Freyther, Harald Welte