Hi Neels,
On Thu, Apr 30, 2020 at 07:43:38PM +0200, Neels Hofmeyr wrote:
Seems like everyone is pointing in a slightly
different direction. But I think
most of our concerns are rather scratching the surface rather than being
substantial deep review on the core implementations of D-GSM.
Agreed. I've now merged the entire patch series as it is so far, we
cannot delay this another couple of months. This obviously doesn't
meant that the code cannot change from how it is now. Anyone is welcome
to improve it in any way.
I know this may not make everyone happy, but we had to do something to
unblock the situation. I value the 5 different lines of thought, but it
seemed we were unable to converge on one particular direction. I could
have taken either of those directions (no real preference either way),
but going for the patches as they are now obviously means we can move
ahead without additional work now.
In hindsight I have the feeling that this development was kept in a
private branch for too long before being submitted to gerrit for review,
until a point it was very far developed and complex. If I'm right
with that feeling, I would strongly encourage a different approach in
future development projects.
Regards,
Harald
--
- Harald Welte <laforge(a)osmocom.org>
http://laforge.gnumonks.org/
============================================================================
"Privacy in residential applications is a desirable marketing option."
(ETSI EN 300 175-7 Ch. A6)