On Wed, Jul 16, 2014 at 07:04:31PM +0200, Daniel Willmann wrote:
- LOGP(DRLCMAC, LOGL_ERROR, "RX: [PCU <- BTS]
%s FIXME: Packet resource request\n", tbf_name(tbf));
+ LOGP(DRLCMAC, LOGL_ERROR, "RX: [PCU <- BTS] %s FIXME: Packet resource
request\n", tbf_name(ul_tbf));
And the compiler just re-inforced me with a warning:
home/ich/install/openbsc/include/osmocom/core/logging.h: In member function 'void
gprs_rlcmac_pdch::rcv_resource_request(Packet_Resource_Request_t*, uint32_t)':
/home/ich/install/openbsc/include/osmocom/core/logging.h:42:53: warning: 'ul_tbf'
may be used uninitialized in this function [-Wmaybe-uninitialized]
logp2(ss, level, __FILE__, __LINE__, 0, fmt, ##args)
After the last if/else either dl_tbf or ul_tbf will be assigned. Maybe just
move the warning into the if/else and remove the declaration of the dl_tbf
ul_tbf.