Hi Harald!
On Mon, Aug 29, 2011 at 09:15:23AM +0200, Harald Welte wrote:
Hi Pablo,
On Sun, Aug 28, 2011 at 11:36:47PM +0200, Pablo Neira Ayuso wrote:
So the
first step would be to add some LOGP messages about which LAPD
instances are allocated (or released). This can be used to see if the
expected LAPD instances (one on each signalling timeslot) are created
or not.
I introduced refcounting in the ->line_update() update path in
libosmo-abis, which calls the setup function only once (I needed this
to avoid binding the A-bis over IP socket twice).
I see. But I believe this is the wrong path to "solve" the problem.
The function is called "update" since it is supposed to be called
multiple times, every time something has changed about the line (e.g.
timeslot configuration).
I can recover the ->start() callback that would be called once for
A-bis over IP drivers, so I don't need to use line_update() for this.
Or add some flag to the lines, so we can know which ones can be
updated several times or not.
Before, the
line_update() function was called once per BTS. I'm
traveling back home, so I didn't have too much time to look in depth,
but my guess is that this can be related to the problem that Gus is
reporting.
With multiple BTS attached to a signle line, there is no other way but
to call the function multiple times. It has to be written with that in
mind.
I missed the multiple-BTS-to-single-line setup, I'll send you a patch
to fix this situation.
Cheers,
Pablo