On Mon, May 19, 2014 at 11:48:47AM +0200, Harald Welte wrote:
Rename NM_ATT_O_REDUCEPOWER to
NM_ATT_OSMO_REDUCEPOWER, which
makes it more clear that this is an osmcoom specific attribute.
Also, we cannot simply overload 0x01 as an already defined OML
attribute. The problem is quite simple: When we use abis_nm_att_tlvdef
during the TLV parse, 0x01 will match to NM_ATT_ABIS_CHANNEL,
which is defined as { TLV_TYPE_FIXED, 3 }.
But we already do have overlap. At least between BS11 and ipaccess.
How is it different from GSM to osmocom? We could argue that the
vendor values should not be in the gsm enum but sit somewhere else?
Can you please elaborate?
I'm using 0xfe for the attribute, as 0xfe
doesn't overlap with the IPA
specific attribues (and we might want to combine/merge the 12.21 plus
IPA plus osmocom spefici attributes)
typo(s). :)