Hi Katerina, thanks for your cleanup patches. However: On Fri, Mar 01, 2013 at 06:31:38PM +0000, Katerina Barone-Adesi wrote:
"phys_chan_config PCHAN", /* dynamically generated! */ - "Physical Channel configuration (TCH/SDCCH/...)") + "Physical Channel configuration (TCH/SDCCH/...)\n" "PCHAN\n")
Does this matter at all? The strings are overridden in bsc_vty_init() with dynamically generated option lists by means of vty_cmd_string_from_valstr(). Maybe I'm missing something, but the "PCHAN" you are adding should never even show up on the VTY. Regards, Harald -- - Harald Welte <laforge@gnumonks.org> http://laforge.gnumonks.org/ ============================================================================ "Privacy in residential applications is a desirable marketing option." (ETSI EN 300 175-7 Ch. A6)