Hi Neels, On Wed, Nov 02, 2016 at 02:14:13PM +0100, Neels Hofmeyr wrote:
case GSM48_MT_RR_STATUS: - LOGP(DRR, LOGL_NOTICE, "RR STATUS (cause: %s)\n", - rr_cause_name(gh->data[0])); + LOGP(DRR, LOGL_NOTICE, "%s (cause: %s)\n", + gsm48_rr_msg_name(GSM48_MT_RR_GPRS_SUSP_REQ),
Although this is in case GSM48_MT_RR_STATUS, it logs GSM48_MT_RR_GPRS_SUSP_REQ. I'd prefer it it logs gsm48_rr_msg_name(msg_type), also in the call above, and like the patch does below.
ACK. Philipp, would be great if you could fix that up. Thanks, Harald -- - Harald Welte <laforge@gnumonks.org> http://laforge.gnumonks.org/ ============================================================================ "Privacy in residential applications is a desirable marketing option." (ETSI EN 300 175-7 Ch. A6)