Patch Set 2: Code-Review-1
(1 comment)
https://gerrit.osmocom.org/#/c/142/2/tests/edge/EdgeTest.cpp
File tests/edge/EdgeTest.cpp:
Line 527: &llc, &write_offset, &num_chunks, data, false, NULL);
I think rather than just not testing the count_payload feature added, you should actually
test the newly-introdcued counting fetaure here, too. I.e. have it count, and OSMO_ASSERT
on the expected number of bits.
--
To view, visit
https://gerrit.osmocom.org/142
To unsubscribe, visit
https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0e622acb1f13f7489946baf049de4ba1cde6a1fc
Gerrit-PatchSet: 2
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Harald Welte <laforge(a)gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: Yes