From Vadim Yanitskiy <axilirator@gmail.com>:
Vadim Yanitskiy has posted comments on this change. Change subject: gsm48: move to hex TMSI representation ...................................................................... Patch Set 1: (2 comments)
(2 comments)
https://gerrit.osmocom.org/#/c/57/1/src/gsm/gsm48.c File src/gsm/gsm48.c: PS1, Line 461:
It is not a "reverse" anymore. Should the comment be updated? Specially wit I think we can simply delete this comment.
PS1, Line 465: string
Why do you prefix it with 0x here? In the commit message I would like to h Because I saw that the 0x%08x format also used in other Osmocom projects, for example in OsmocomBB. Well, the minimum ant the maximum size of the string is always constant and equal to 2 + 8 = 10 (without '\0').
It is mostly consumed by user, so I think we should use the most comfortable for reading format. Would you prefer to avoid the '0x' prefix in this case? Also, what about using '%08X' instead of '%08x'? -- To view, visit https://gerrit.osmocom.org/57 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifd25365bfa3b4ee95b16979740c3229948ce17f2 Gerrit-PatchSet: 1 Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Owner: Vadim Yanitskiy <axilirator@gmail.com> Gerrit-Reviewer: Holger Freyther <holger@freyther.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy <axilirator@gmail.com> Gerrit-HasComments: Yes